Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay run mode #2331

Merged
merged 6 commits into from
May 31, 2024
Merged

Replay run mode #2331

merged 6 commits into from
May 31, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented May 23, 2024 •
edited
Loading

Fixes NIT-2531
pulls in OffchainLabs/go-ethereum#320
creates new runmode for messageReplay. It has the same on-chain behavior as messageCommit on execution, but not on caching.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 23, 2024
@tsahee tsahee requested a review from PlasmaPower May 23, 2024 02:23
PlasmaPower
PlasmaPower approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge May 30, 2024 23:49
@tsahee tsahee merged commit 7928b81 into master May 31, 2024
10 checks passed
@tsahee tsahee deleted the replay_run_mode branch May 31, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @PlasmaPower